Generate Historic Data, Showing In Simple Table #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, this is very important
✅ Deploy Preview for radiant-cucurucho-d09bae ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Idea for improvement: Hide columns that never have data (e.g. the Energy Star Score in the PR description screenshot from Merch Mart) since there's no point comparing something with no data at all. |
alexkcode
approved these changes
May 8, 2024
pldorn
approved these changes
May 8, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // A column is empty if it's all empty string or '0', so skip it if so. Some columns switch | ||
| // between both, like Natural Gas Use on Merch Mart, which we also want to ignore | ||
| return !this.historicBenchmarks.every((datum) => { | ||
| return (datum as any)[colKey] === '' || (datum as any)[colKey] === '0.0'; |
Check warning
Code scanning / ESLint
Disallow the `any` type Warning
| // A column is empty if it's all empty string or '0', so skip it if so. Some columns switch | ||
| // between both, like Natural Gas Use on Merch Mart, which we also want to ignore | ||
| return !this.historicBenchmarks.every((datum) => { | ||
| return (datum as any)[colKey] === '' || (datum as any)[colKey] === '0.0'; |
Check warning
Code scanning / ESLint
Disallow the `any` type Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the data process to generate a new
benchmarking-all-years.csv, which contains a smaller set of columns with historic data, so we can see emissions and energy use change over time, and adds a simple table view to render this data. This isn't elegant, but is better than not having the data at all.Demo From Merchandise Mart:
Note: Only columns with any values will be rendered, to reduce noise. So for Merchandise Mart, the Energy Star Score or District Heating is not shown over time.
Resolves #73
Testing Instructions
Confirmed that historical data renders properly on a variety of pages - even if a building only has one year of data, the table should render fine. Also made sure the table works well on mobile by scrolling it horizontally.
Checklist: